-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image gallery template: add optional alt text and hyperlink properties. Also ensure descr is shown in all layouts. #470
Comments
Will need to include some consideration of the other shipped templates too... Easy enough to add extra fields to the edit and the render views for this one template, but... Also need to be cautious that existing pages store a 'SerializedModel' field with a JSON serialization of the current viewmodel… so will pages made with the old version of the template have problems on migration to the newer version, since their JSON model will be lacking the new properties expected in the template editor... that needs testing. |
I have an implementation of this that works for me... subject to more testing of the two issues in previous comment. (watch for js console errors.) Feature/470 branch - I did not PR this yet. Actually the only other template that shares the same knockout script seems to be the 'Everything' template (which I think is probably the same as 'flexible complex') |
Also removed carousel-fade class from the carousel (request of Stewart B) |
I think I can just bump the version of cloudscribe.SimpleContent.ContentTemplates.Bootstrap4 since the VSIX has a direct dependency on it. (Tested that locally.) Tested that old pages using the same template survive the upgrade. |
#470 Adding Alt text and hyperlink support to image gallery template
This was pushed to nuget.org as v3.0.2 of cloudscribe.SimpleContent.ContentTemplates.Bootstrap4 There is no BS3 equivalent project, so ticket can be closed once satisfied that it's been sufficiently tested. |
Often the description is not appropriate alt text for an image. Also, we may want the image title to be a hyperlink to some other page. This should work in all layout options.
Also noticed that the Description is not visible in full-width carousel... entered properties should be visible in all layouts.
The text was updated successfully, but these errors were encountered: