Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script links added to content pages vanish again when those pages are re-ordered via the admin UI #556

Closed
JimKerslake opened this issue Jan 16, 2023 · 1 comment
Closed

Script links added to content pages vanish again when those pages are re-ordered via the admin UI #556

JimKerslake opened this issue Jan 16, 2023 · 1 comment
Assignees
@JimKerslake
Labels
bug

Comments

@JimKerslake
Copy link
Collaborator

Add a JS script link to a simplecontent page, using the Developer tools button.
Then use the Page Management tool in the admin UI to re-order the pages.
They seem to lose their script links.
@JimKerslake JimKerslake self-assigned this Jan 16, 2023
JimKerslake added a commit that referenced this issue Feb 3, 2023
@JimKerslake
#556 page reordering bug - loss of external references
eeab8c4
JimKerslake added a commit that referenced this issue Feb 3, 2023
@JimKerslake
Merge pull request #558 from cloudscribe/feature/556
dd45947 
#556 page reordering bug - loss of external references
@JimKerslake
Copy link
Collaborator Author

This was down to an EF Core query missing the .Include for referential properties
(plus some workaround code for this query being .AsNoTracking() )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimKerslake JimKerslake

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JimKerslake