Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elbow connectors connect to the wrong spot when page is refreshed #150

Closed
brtkwr opened this issue Oct 4, 2021 · 5 comments
Closed

Elbow connectors connect to the wrong spot when page is refreshed #150

brtkwr opened this issue Oct 4, 2021 · 5 comments
Labels
bug Something isn't working
Projects

Comments

@brtkwr
Copy link

brtkwr commented Oct 4, 2021

Describe the bug
When the app is refreshed, the elbow connecters which were connected to the left dot of an icon move to the bottom for example making the allow go in a route not drawn when it is saved.

@brtkwr brtkwr added the bug Something isn't working label Oct 4, 2021
@mithunshanbhag
Copy link
Contributor

Hi @brtknr: This is a known issue with elbow connectors. Unfortunately, the fix is non-trivial and might also break backward compatibility with existing diagrams. Looking into this.

@brtkwr
Copy link
Author

brtkwr commented Oct 4, 2021

Whats the workaround? Do you recommend a different connector? Why is the elbow connector the default one if its broken?

@mithunshanbhag
Copy link
Contributor

mithunshanbhag commented Oct 4, 2021

Unfortunately, no workarounds exist for this issue.
Curved connector and line connectors do not encounter this issue.

Background: The elbow connectors use an "aggressive" routing strategy to bypass existing shapes/text on the canvas. While the user can re-route the elbow connector, it accidentally defaults to the aggressive routing strategy on page refreshes (hence the bug).

Apologies for the bad experience, will do my best to fix this.

@brtkwr
Copy link
Author

brtkwr commented Oct 4, 2021

Thanks for looking into it. Please default to curved connectors until the issue is fixed at least (e.g. when you drag from the point of an icon to another one).

@mithunshanbhag
Copy link
Contributor

mithunshanbhag commented Dec 7, 2021

Update: You can now attach connectors to:

  • a specific dock on the symbol. OR
  • the symbol itself.

The former will always stay attached to the specific dock, while the latter will dynamically route itself for the shortest path.

In below example, the yellow connector is attached to the symbol's dock, while the purple connector is attached to the symbol.

Note: This will only work for newer symbols loaded on the diagram canvas. Existing symbols (already on the canvas) will not be affected by this change.

GIF 12-7-2021 5-16-57 PM

@mithunshanbhag mithunshanbhag added this to To do in cloudskew via automation Dec 10, 2021
@mithunshanbhag mithunshanbhag moved this from To do to Done in cloudskew Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
cloudskew
  
Done
Development

No branches or pull requests

2 participants