PRO-752: Calculate package checksum locally when downloaded

[BartoszBlizniak]

Previously, we were grabbing the package checksum via our API which meant that the checksum could be out-of-sync whenever a package is re-published due to caching. This commit ensures that the checksums that are being returned are from the downloaded package and when the package is not downloaded, the checksums will then be returned from the API.

[lskillen]

This is really awesome; I think we need a little bit extra to make this safe.

We should also really add an additional test/coverage for the branches (and new logic) here as well to cloudsmith/data_source_package_test.go - creating more work for you Bart, sorry, but better to be safe! 🙏

Happy to get you some help and extra eyes if wanted. 😁

[dgonzalez]

Aside from Lee's comment, a nit pick that you can ignore but looks good from my side.

[BartoszBlizniak]

Hey, I've added the logic for re-try and updated the test, could I get another 👀

[lskillen]

Few wee comments; main one is to force a failure instead of a warning. :)

[BartoszBlizniak]

Hey @lskillen - are we okay to release this or are there some other things that I should change here?

[estebangarcia]

I might be late to the party but have a couple of suggestions.

[lskillen]

I might be late to the party but have a couple of suggestions.

These are more or less the same feedback for me, but I was thinking of a live share with Bart and we can get this over the line; do you fancy doing a VSCode Live Share session with Bart, @estebangarcia? I reckon you two could knock it out pretty quickly!

[BartoszBlizniak]

Would be happy to! Just throw something into my calendar when suits the best :)

[BartoszBlizniak]

Thanks @estebangarcia for the session! @lskillen - if you'd like to glance over final code and I can get it shipped out

[lskillen]

Looks sane to me 👍 ... except for the use of tabs everywhere, which is Not Your Fault.

Something something eternal holy war. 😂 (tbh, I'm not precious about it, but we're spaces everywhere else!)

[BartoszBlizniak]

Looks sane to me 👍 ... except for the use of tabs everywhere, which is Not Your Fault.

Something something eternal holy war. 😂 (tbh, I'm not precious about it, but we're spaces everywhere else!)

tabs > spaces

[lskillen]

Looks sane to me 👍 ... except for the use of tabs everywhere, which is Not Your Fault.
Something something eternal holy war. 😂 (tbh, I'm not precious about it, but we're spaces everywhere else!)

tabs > spaces

(I know tabs are the default for go fmt and friends)

OK, but you can rewrite the rest of the codebase using tabs. :p