Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 108 - Fix for Firestore database create cmd. #113

Merged
merged 10 commits into from
May 10, 2023

Conversation

AkshayKalbhor
Copy link
Contributor

Modified the readme files for updates regarding the correct command to create firestore database.

@davidcueva davidcueva self-requested a review May 8, 2023 11:52
@davidcueva
Copy link
Collaborator

Hi Akshay, thanks for the PR.

I tested it but got an error when running:

gcloud firestore databases create --location="${FIRESTORE_DB_LOCATION}"

ERROR: (gcloud.firestore.databases.create) Resource in projects [...] is the subject of a conflict: Database already exists. Please use another database_id

This is because after gcloud app create --region="${APP_ENGINE_LOCATION}", a Firestore DB is already created in Datastore mode.

My suggestion: Use firestore update to native instead of create, see here

@AkshayKalbhor
Copy link
Contributor Author

Hello David,
thanks for your suggestion, I have updated the files, please review them according to your convenience.

@davidcueva davidcueva merged commit a49b35f into cloudspannerecosystem:master May 10, 2023
4 checks passed
@davidcueva
Copy link
Collaborator

Thanks Akshay !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcloud command to create Firestore database is incorrect
2 participants