-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 108 - Fix for Firestore database create cmd. #113
Merged
davidcueva
merged 10 commits into
cloudspannerecosystem:master
from
AkshayKalbhor:master
May 10, 2023
Merged
fix: 108 - Fix for Firestore database create cmd. #113
davidcueva
merged 10 commits into
cloudspannerecosystem:master
from
AkshayKalbhor:master
May 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d [gke with the correct Firestore create command parameter
Hi Akshay, thanks for the PR. I tested it but got an error when running:
This is because after My suggestion: Use firestore |
Hello David, |
davidcueva
approved these changes
May 10, 2023
Thanks Akshay ! |
Closed
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the readme files for updates regarding the correct command to create firestore database.