Show progress of CREATE INDEX #113

apstndb · 2021-04-14T07:45:57Z

Currently, spanner-cli doesn't show anything until CREATE INDEX is done.

Recently, Cloud Spanner supports tracking of the progress of index backfill operations.
https://cloud.google.com/spanner/docs/release-notes#April_06_2021

You can now track the progress of long-running index backfill operations through the gcloud command line tool, REST API, and RPC API. For more information, see Checking the progress of a secondary index backfill.

So we can show progress of index creation using polling.

Consideration

How to visualize progress?
- Bar or percent?
- With elapsed time
Multiple DDL statements
- mix of CREATE INDEX and other DDLs which doesn't support progressPercent .

The text was updated successfully, but these errors were encountered:

yfuruyama · 2021-04-14T08:12:11Z

Thanks for filing the feature request. I was thinking of the same thing 👍

Bar or percent?

I prefer percent for simplicity, but basically both are fine. Besides the percent, it would be better to show the elapsed time to make it possible to guess when the backfill will finish.

Multiple DDL statements

I think the most time consuming task for updating DDL would be index backfilling, so it might make sense to show the index backfill progress even if it contains other DDL statements.

Other consideration is whether we show index backfill progress when it's running as batch mode. If it shows the progress, I think spanner-cli would be the good alternative to gcloud spanner databases ddl update for users.

apstndb · 2021-04-14T10:05:33Z

Blocker:
UpdateDatabaseDdlMetadata.progress is not yet added into UpdateDatabaseDdlMetadata struct.

apstndb · 2021-04-15T02:46:51Z

progress has added.
googleapis/go-genproto@9228244

apstndb · 2021-04-15T07:12:25Z

I don't have a concrete idea yet for the actual implementation in spanner-cli but I prototyped some output formats using the real UpdateDatabaseDdlMetadata.

Note: The elapsed time may rewind because the final end_time can be older than the previous call.

Rewriting a single line

Rewriting multiple lines

Non-rewriting multiple lines(for non-tty output)

yfuruyama · 2021-04-15T07:27:46Z

Thanks for creating some prototypes. These are great resources to think about an appropriate format.

Rewriting multiple lines

Personally I prefer this one, but if it's hard to implement this, I think it's adequate to use "Rewriting a single line" pattern.

Non-rewriting multiple lines(for non-tty output)

I think it's common to see this pattern in some build logs like CircleCI's or Cloud Build's when we try to rewrite the output line. I'm not sure, but can't we rewrite the line if we run spanner-cli as a batch mode?

apstndb · 2021-04-15T07:59:28Z

Rewriting multiple lines

Personally I prefer this one, but if it's hard to implement this, I think it's adequate to use "Rewriting a single line" pattern.

I think it isn't so hard but I didn't yet think the change to program structure and portable implementation of rewriting(like Windows support).

I think it's common to see this pattern in some build logs like CircleCI's or Cloud Build's when we try to rewrite the output line. I'm not sure, but can't we rewrite the line if we run spanner-cli as a batch mode?

I think ordinal executions of the batch mode in a terminal is suited for rewriting multiple-line format.
(Actually, the interactive mode doesn't support batch execution of DDL statements.)

I have experienced the case that some CI build log has broken(including unprocessed escape sequences) because the execution environment is tty but build log doesn't support escape sequences.
So I think it may be better to support a flag to force non-rewriting format.
(cmd < /dev/null may be a workaround.)

apstndb · 2021-04-15T08:10:44Z

Consideration about "non-rewriting multiple lines":

Output when:
- periodic even if there are no changes.
- a status for each statement has updated.
  - end_time or progress_percent
- a statement has finished.

yfuruyama · 2021-04-15T08:30:27Z

I think it isn't so hard but I didn't yet think the change to program structure and portable implementation of rewriting(like Windows support).

I think it's better to use a well-tested library to rewrite the line. One of the examples is gosuri/uilive which supports windows.

I have experienced the case that some CI build log has broken(including unprocessed escape sequences) because the execution environment is tty but build log doesn't support escape sequences.
So I think it may be better to support a flag to force non-rewriting format.

I'm not completely sure, but can we say it's a rare case? If it happens on the major CI providers like CircleCI or Cloud Build, it might be better to add such a flag, but if it's not, I don't think adding more flag is a good option because there is a workaround. Please correct me if my assumption is wrong.

apstndb · 2021-04-15T09:13:11Z

I'm not completely sure, but can we say it's a rare case? If it happens on the major CI providers like CircleCI or Cloud Build, it might be better to add such a flag, but if it's not, I don't think adding more flag is a good option because there is a workaround. Please correct me if my assumption is wrong.

Yeah, I think it is a major case.

Test repo
https://github.com/apstndb/circleci-sandbox

CircleCI

CircleCI seems to completely ignore unsupported ANSI escape code(no handling).

version: 2
jobs:
  build:
    docker:
      - image: ubuntu
    steps:
      - run: for i in $(seq 1 10); do echo "\033[F\033[2K${i}" && sleep 1; done

Cloud Build

Cloud Build doesn't support to rewrite and only strip ANSI escape code.

steps:
    - name: ubuntu
      entrypoint: /bin/sh
      args:
          - -c
          - |
              for i in $(seq 1 10); do echo "\033[F\033[2K${i}" && sleep 1; done

Refs:

Implement a way to enable color in console even when the output is redirected dotnet/runtime#33980

apstndb · 2021-04-15T09:20:05Z

I think many tools see CI environment variable to switch behavior but Cloud Build doesn't populate that variable..

yfuruyama · 2021-04-15T09:27:43Z

Thank you for quickly trying out on some CI providers!

I think many tools see CI environment variable to switch behavior but Cloud Build doesn't populate that variable..

Ah that's a good idea. Even though we have to add some logic in ad hoc way, that looks better than providing a new flag.

apstndb · 2021-04-15T09:41:03Z

Little correction:
The case of CircleCI seems wrong because echo of bash doesn't print the escape character without -e option.

It is similar result with Cloud Build's one.

apstndb · 2021-04-15T10:00:55Z

Related discussion in CircleCI Discuss.

Disable interactive mode (TTY) - ‘pip’ and progress bars problem

I think format like "Rewriting multiple lines" will be broken in major CI and file redirection so non-rewriting mode is needed but flag is not mandatory if some workaround is documented.(cmd < /dev/null, cmd | tee, cmd | cat, etc.)

apstndb · 2021-04-15T11:28:57Z

Another choice:

At the beginning, show progress only if it runs on tty regardless interactive mode or batch mode.
- It will be silent on non-tty as same as current behavior.

yfuruyama · 2021-04-16T01:58:52Z

At the beginning, show progress only if it runs on tty regardless interactive mode or batch mode.
It will be silent on non-tty as same as current behavior.

Yeah that would be a viable option. But I'm wondering the use case where users need to run CREATE INDEX on the CI build system and check the progress of index backfilling in real time.

To cover that use case, what about always rewriting the lines and documenting the workaround for users who don't want that behavior?

apstndb · 2021-04-16T06:17:48Z

To cover that use case, what about always rewriting the lines and documenting the workaround for users who don't want that behavior?

Does "always" means regardless of whether or not on tty?
I think if there is no alternative mode, users can't do any workaround because I think the workaround is to force it into non-tty(non-rewriting format) mode.

yfuruyama · 2021-04-16T06:43:30Z

If I understand correctly the results of your experiments on CircleCI and Cloud Build, both CI systems just ignores the escape character for erasing the line. So if spanner-cli attempts to rewrite the line on those environments, it would show the following long listing outputs:

 0% CREATE INDEX xxxx : elapsed_time: 10s
 5% CREATE INDEX xxxx : elapsed_time: 15s
10% CREATE INDEX xxxx : elapsed_time: 20s
...

So I wanted to mean if a user doesn't want to be bothered with long listing outputs on non-tty environment like the preceding example, then I think they can suppress the output with > /dev/null; it becomes the same behavior as the current's.

One thing I don't fully understand is how turning the stdin/stdout to non-tty mode becomes the workaround for users who bothers with the broken log output (escape character is shown as it is) or long listing output like the above example. Could you elaborate on that?

apstndb · 2021-04-16T07:24:49Z

If I understand correctly the results of your experiments on CircleCI and Cloud Build, both CI systems just ignores the escape character for erasing the line. So if spanner-cli attempts to rewrite the line on those environments, it would show the following long listing outputs:

I think rewriting multiple-line output format isn't suitable without rewriting because it is multiple-lines and short interval update of elapsed_time even if there are no update in operation status.

If there are 4 statements in batch, output will be shown as below.

  0% CREATE INDEX TestIndex11 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 0s
  0% DROP INDEX TestIndex11: elapsed_time: 0s
  0% CREATE INDEX TestIndex12 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 0s
  0% DROP INDEX TestIndex12: elapsed_time: 0s
  0% CREATE INDEX TestIndex11 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 5s
  0% DROP INDEX TestIndex11: elapsed_time: 0s
  0% CREATE INDEX TestIndex12 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 0s
  0% DROP INDEX TestIndex12: elapsed_time: 0s
  0% CREATE INDEX TestIndex11 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 10s
  0% DROP INDEX TestIndex11: elapsed_time: 0s
  0% CREATE INDEX TestIndex12 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 0s
  0% DROP INDEX TestIndex12: elapsed_time: 0s
 10% CREATE INDEX TestIndex11 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 15s
  0% DROP INDEX TestIndex11: elapsed_time: 0s
  0% CREATE INDEX TestIndex12 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 0s
  0% DROP INDEX TestIndex12: elapsed_time: 0s
...
100% CREATE INDEX TestIndex11 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 1h
100% DROP INDEX TestIndex11: elapsed_time: 1h
100% CREATE INDEX TestIndex12 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 1h
  0% DROP INDEX TestIndex12: elapsed_time: 59m55s
100% CREATE INDEX TestIndex11 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 1h
100% DROP INDEX TestIndex11: elapsed_time: 1h
100% CREATE INDEX TestIndex12 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 1h
100% DROP INDEX TestIndex12: elapsed_time: 1h

(progressPercent was not granular at least my case.)

There may be some improvement(like separator) but basically it emit huge sized logs(in above format, <num of statements> × <total elapsed time> / <interval> lines).
I think these huge output is not well-readable and not suitable to some CI service logs viewer.

Non-rewriting output mode can resolve problems.

Can print only the current executed statement at once.
Can print only when a status of the statement is updated.
- or longer interval for non-rewriting mode.

Below is the case of printing current statement when status changed or 10m interval.

1/4   0% CREATE INDEX TestIndex11 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 0s
1/4  10% CREATE INDEX TestIndex11 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 15s
...
1/4 100% CREATE INDEX TestIndex11 ON Albums(AlbumTitle, MarketingBudget): elapsed_time: 1h
2/4   0% DROP INDEX TestIndex11: elapsed_time: 0s
2/4   0% DROP INDEX TestIndex11: elapsed_time: 10m
...
2/4 100% DROP INDEX TestIndex11: elapsed_time: 1h
...
4/4 100% DROP INDEX TestIndex12: elapsed_time: 1h

yfuruyama · 2021-04-16T07:41:39Z

That makes sense. Thanks for describing the disadvantage of rewriting the lines on CI systems 👍

Okay, for the simplicity, how about using he following two different modes for showing the index backfill progress?

Rewrite lines in real time; this is for users who uses spanner-cli with interactive mode (assuming that it has a tty).
Append lines whenever the progress is changed or some time passed; this is for users who uses spanner-cli with batch mode (it may or may not have a tty).

apstndb · 2021-04-16T09:16:12Z

Rewrite lines in real time; this is for users who uses spanner-cli with interactive mode (assuming that it has a tty).

Append lines whenever the progress is changed or some time passed; this is for users who uses spanner-cli with batch mode (it may or may not have a tty).

Interactive mode doesn't support batch execution of multiple statements so it means:

(Interactive mode) Rewrite a progress for single statement in realtime(short interval).
(Batch mode) Append a line of progressing statement(triggered by status change or longer interval).

yfuruyama · 2021-04-16T09:26:22Z

That looks good to me 👍

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show progress of CREATE INDEX #113

Show progress of CREATE INDEX #113

apstndb commented Apr 14, 2021 •

edited

yfuruyama commented Apr 14, 2021

apstndb commented Apr 14, 2021 •

edited

apstndb commented Apr 15, 2021

apstndb commented Apr 15, 2021 •

edited

yfuruyama commented Apr 15, 2021

apstndb commented Apr 15, 2021 •

edited

apstndb commented Apr 15, 2021

yfuruyama commented Apr 15, 2021 •

edited

apstndb commented Apr 15, 2021 •

edited

apstndb commented Apr 15, 2021

yfuruyama commented Apr 15, 2021

apstndb commented Apr 15, 2021 •

edited

apstndb commented Apr 15, 2021 •

edited

apstndb commented Apr 15, 2021

yfuruyama commented Apr 16, 2021

apstndb commented Apr 16, 2021 •

edited

yfuruyama commented Apr 16, 2021

apstndb commented Apr 16, 2021 •

edited

yfuruyama commented Apr 16, 2021

apstndb commented Apr 16, 2021

yfuruyama commented Apr 16, 2021

Show progress of CREATE INDEX #113

Show progress of CREATE INDEX #113

Comments

apstndb commented Apr 14, 2021 • edited

Consideration

yfuruyama commented Apr 14, 2021

apstndb commented Apr 14, 2021 • edited

apstndb commented Apr 15, 2021

apstndb commented Apr 15, 2021 • edited

Rewriting a single line

Rewriting multiple lines

Non-rewriting multiple lines(for non-tty output)

yfuruyama commented Apr 15, 2021

apstndb commented Apr 15, 2021 • edited

apstndb commented Apr 15, 2021

Consideration about "non-rewriting multiple lines":

yfuruyama commented Apr 15, 2021 • edited

apstndb commented Apr 15, 2021 • edited

CircleCI

Cloud Build

apstndb commented Apr 15, 2021

yfuruyama commented Apr 15, 2021

apstndb commented Apr 15, 2021 • edited

apstndb commented Apr 15, 2021 • edited

apstndb commented Apr 15, 2021

yfuruyama commented Apr 16, 2021

apstndb commented Apr 16, 2021 • edited

yfuruyama commented Apr 16, 2021

apstndb commented Apr 16, 2021 • edited

yfuruyama commented Apr 16, 2021

apstndb commented Apr 16, 2021

yfuruyama commented Apr 16, 2021

apstndb commented Apr 14, 2021 •

edited

apstndb commented Apr 14, 2021 •

edited

apstndb commented Apr 15, 2021 •

edited

apstndb commented Apr 15, 2021 •

edited

yfuruyama commented Apr 15, 2021 •

edited

apstndb commented Apr 15, 2021 •

edited

apstndb commented Apr 15, 2021 •

edited

apstndb commented Apr 15, 2021 •

edited

apstndb commented Apr 16, 2021 •

edited

apstndb commented Apr 16, 2021 •

edited