Change request tags to a combination of transaction tags + sequence num + SQL text. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takabow
commented
Nov 10, 2022
| iter := s.tc.rwTxn.QueryWithOptions(ctx, stmt, opts) | ||
| s.tc.sendHeartbeat = true | ||
| return iter, nil | ||
| } | ||
| if s.InReadOnlyTransaction() { | ||
| opts.RequestTag = s.tc.tag | ||
| opts.RequestTag = generateRequestTag(s.tc, stmt) |
There was a problem hiding this comment.
I noticed that SHOW INDEX and SHOW COLUMNS fall into this section in a RO transaction. It should be fix.
takabow
force-pushed
the
fix/change-request_tags-behavior
branch
from
9a67221
to
fe7cb95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spanner-cli has embedded in the request tag the same thing as the transaction tag. However, Cloud Spanner groups queries with the same request tag in query stats as the same. Therefore, to make it easier to identify individual queries issued by spanner-cli in query stats, the
request taghas been changed to betransaction tags + sequential number + SQL text.This PR fix #132.