Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Partitioned DML #93

Closed
yfuruyama opened this issue Oct 17, 2020 · 3 comments · Fixed by #94
Closed

Support Partitioned DML #93

yfuruyama opened this issue Oct 17, 2020 · 3 comments · Fixed by #94
Assignees

Comments

@yfuruyama
Copy link
Collaborator

Cloud Spanner has two execution modes for DML, DML and Partitioned DML, but currently spanner-cli only supports normal DML. It would be better to support Partitioned DML in spanner-cli since it can process large-scale operations over the entire rows.

One thing we might need to discuss would be syntax for executing a Partitioned DML.

Context: #92 (comment)

@yfuruyama
Copy link
Collaborator Author

@apstndb You mentioned EXECUTE PARTITIONED (INSERT|UPDATE|DELETE) ... as an example for the syntax in #92 (comment), but what is the rationale behind it?

I'm wondering if we can make it simpler by just saying PARTITIONED (INSERT|UPDATE|DELETE) ... to indicate executing the DML as a Partitioned DML.

@apstndb
Copy link
Collaborator

apstndb commented Oct 17, 2020

EXECUTE PARTITIONED (INSERT|UPDATE|DELETE) is inspired by EXECUTE IMMEDIATE but only for example and no rationale.
It may be even wrong because of ambiguous syntax with the standard Dynamic SQL(EXECUTE IMMEDIATE, PREPARE and EXECUTE).

I want to vote PARTITIONED (INSERT|UPDATE|DELETE) ... because it is simple and unambiguous.

@yfuruyama
Copy link
Collaborator Author

Sounds good, then let's use PARTITIONED (INSERT|UPDATE|DELETE) ... for the syntax. I'll take on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants