Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test is flaky or the build is broken #8

Closed
rakyll opened this issue May 29, 2020 · 1 comment · Fixed by #10
Closed

Test is flaky or the build is broken #8

rakyll opened this issue May 29, 2020 · 1 comment · Fixed by #10

Comments

@rakyll
Copy link

rakyll commented May 29, 2020

Looks like it might be a timezone issue. See the log below:

 go test ./...
--- FAIL: TestDecodeColumn (0.00s)
    --- FAIL: TestDecodeColumn/date (0.00s)
        decoder_test.go:282: DecodeColumn(2018-01-22) = "DATE \"2018-01-22\"", want = "DATE \"2018-01-23\""
    --- FAIL: TestDecodeColumn/array_date (0.00s)
        decoder_test.go:282: DecodeColumn([2018-01-22 2018-01-23]) = "[DATE \"2018-01-22\", DATE \"2018-01-23\"]", want = "[DATE \"2018-01-23\", DATE \"2018-01-24\"]"
FAIL
FAIL	github.com/cloudspannerecosystem/spanner-dump	0.191s
FAIL
yfuruyama added a commit that referenced this issue May 29, 2020
@yfuruyama
Fix #8: considre time zone for generating date
646a457
@yfuruyama yfuruyama mentioned this issue May 29, 2020
Merged
@yfuruyama
Copy link
Collaborator

Thank you for catching this issue. Actually this is timezone issue.

Fixed: #10

yfuruyama added a commit that referenced this issue May 29, 2020
@yfuruyama
Fix #8: considre time zone for generating date (#10)
d32a95b 
* Fix #8: considre time zone for generating date

* Tweak method name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #8: considre time zone for generating date cloudspannerecosystem/spanner-dump
2 participants
@rakyll @yfuruyama