Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASToptions_clause is missing equals method #117

Closed
gurminder71 opened this issue Jun 2, 2024 · 0 comments · Fixed by #138 or #139
Closed

ASToptions_clause is missing equals method #117

gurminder71 opened this issue Jun 2, 2024 · 0 comments · Fixed by #138 or #139

Comments

@gurminder71
Copy link
Contributor

Any change in SEARCH INDEX cannot be generated the it is detecting that options have changed.

diff --git a/src/main/java/com/google/cloud/solutions/spannerddl/parser/ASToptions_clause.java b/src/main/java/com/google/cloud/solutions/spannerddl/parser/ASToptions_clause.java
index 47cd75c..ff206c7 100644
--- a/src/main/java/com/google/cloud/solutions/spannerddl/parser/ASToptions_clause.java
+++ b/src/main/java/com/google/cloud/solutions/spannerddl/parser/ASToptions_clause.java
@@ -42,4 +42,9 @@ public class ASToptions_clause extends SimpleNode {
     return AstTreeUtils.getChildrenAssertType(children, ASToption_key_val.class).stream()
         .collect(Collectors.toMap(ASToption_key_val::getKey, ASToption_key_val::getValue));
   }
+
+  @Override
+  public boolean equals(Object obj) {
+    return toString().equals(obj.toString());
+  }
 }
nielm added a commit to nielm/spanner-schema-diff-tool that referenced this issue Jun 19, 2024
nielm added a commit to nielm/spanner-schema-diff-tool that referenced this issue Jun 19, 2024
@nielm nielm closed this as completed in 1fddeea Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant