Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Custom' variant option resets to 'Primary' #34

Closed
kochetov-dmitrij opened this issue Nov 24, 2020 · 1 comment
Closed

'Custom' variant option resets to 'Primary' #34

kochetov-dmitrij opened this issue Nov 24, 2020 · 1 comment

Comments

@kochetov-dmitrij
Copy link

When I use 'Custom' variant, save my dashboard and reload the page, the variant option resets to 'Primary'.
Because Grafana doesn't save undefined values into json configs, it uses the defaultValue which is 'primary'.

What is the point of using undefined value instead of 'custom' str?

cloudspout-button-panel/src/module.ts

Line 107 in 743a01b

value: undefined,

derjust added a commit that referenced this issue Nov 24, 2020
@derjust
Variant was not properly saved
b885a23 
As reported by #34 `undefined` is not saved in Grafana - so the panel was not properly working after saving/reloading it.

This commit fixes this.
@derjust
Copy link
Contributor

derjust commented Nov 24, 2020

Using undefinied was used to not invent a new value to store.

Thanks for reporting. Fixed in b885a23

@derjust derjust closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derjust @kochetov-dmitrij