Skip to content

Commit

Permalink
No reason for region on the stack really
Browse files Browse the repository at this point in the history
Since you can get the region with Ref("AWS::Region") this is pretty
silly.  Only the builder needs to know for AWS connections.
  • Loading branch information
phobologic committed Mar 17, 2015
1 parent 2ce7f0c commit 30485fa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion stacker/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def build_template(self, stack_config):
raise AttributeError("Stack class %s does not have a "
"'rendered' "
"attribute." % (class_path))
template = cls(self.region, name=stack_name, mappings=self.mappings,
template = cls(name=stack_name, mappings=self.mappings,
config=stack_config)
self.stacks[stack_name].template = template
return template
Expand Down
6 changes: 1 addition & 5 deletions stacker/stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
class StackTemplateBase(object):
"""Base implementation for dealing with a troposphere template.
:type region: string, AWS region
:param region: The AWS region where this stack will be deployed.
:type name: string
:param name: A name for the stack template. If not provided, one
will be created from the class name automatically.
Expand All @@ -23,8 +20,7 @@ class StackTemplateBase(object):
:param config: A dictionary which is used to pass in configuration info
to the stack.
"""
def __init__(self, region, name, config, mappings=None):
self.region = region
def __init__(self, name, config, mappings=None):
self.name = name
self.mappings = mappings
self.config = config
Expand Down

0 comments on commit 30485fa

Please sign in to comment.