Wrong use of json_checker in ssm.py causing errors #1260
Comments
markpeek
added a commit
that referenced
this issue
Jan 12, 2019
The json_checker validator was being used in both a 1 and 2 argument manner across the code base. This change removes the name parameter to allow for usage as an attribute validator.
|
Nice catch! Surprised more people weren't seeing issues. I just pushed a change to resolve it. |
davemasino
pushed a commit
to davemasino/troposphere
that referenced
this issue
Oct 17, 2019
The json_checker validator was being used in both a 1 and 2 argument manner across the code base. This change removes the name parameter to allow for usage as an attribute validator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think there's an issue with the way the
json_checkeris being used in https://github.com/cloudtools/troposphere/blob/master/troposphere/ssm.py#L38This validator is supposed to take 2 arguments as input but if used as an attribute type, it will only get one thus spitting the following error:
I think it is supposed to be used as part of another validator that can be used as an attribute type, see here for an example:
troposphere/troposphere/apigateway.py
Line 304 in d468285
The text was updated successfully, but these errors were encountered: