Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS template - "Engine" required even when "DBSnapshotIdentifier" is set #581

Closed
robinrob opened this issue Oct 4, 2016 · 0 comments
Closed

Comments

@robinrob
Copy link

robinrob commented Oct 4, 2016

When creating an RDS instance using a Cloudformation template, the "Engine" property should not be required when "DBSnapshotIdentifier" is set, according to the Cloudformation documentation here:
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-rds-database-instance.html#cfn-rds-dbinstance-engine

However even when i have set "DBSnapshotIdentifier" i am getting the following error:
ValueError: Resource Engine required in type AWS::RDS::DBInstance
Which goes away when i set the "Engine" property.

Here is a minimal template demonstrating the issue:

#!/usr/bin/env python

from troposphere import Template
from troposphere.rds import DBInstance

template = Template()

rds_instance = template.add_resource(DBInstance(
    'MyDB',
    DBName='test',
    AllocatedStorage=25,
    DBInstanceClass='db.m4.large',
    DBSubnetGroupName='default',
    DBSnapshotIdentifier='id'
))

print template.to_json()

Thanks.

amosshapira pushed a commit to amosshapira/troposphere that referenced this issue Oct 24, 2016
…loudtools#583)

* Fixes cloudtools#581
* Update to verify engine later in the process
* Update patch according to recommendations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Next Release
Completed
Development

No branches or pull requests

1 participant