Eliminate infinite loop when pickle loads BaseAWSObject and objects derived from it. #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..., which caused build to break.
|
Hey @satvidh - thanks for the PR. I've gone ahead and added a test for the issue this has fixed, and I'm going to merge this. Thanks again, and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pickle loads this object, then getattr will cause an infinite loop when pickle invokes this object to look for setstate before attributes is "loaded" into this object. Therefore, short circuit the rest of this call if attributes is not loaded yet. See http://grokbase.com/t/python/python-bugs-list/092sczhjwk/issue5370-unpickling-vs-getattr for source of this change.