Made DataSourceName non-mandatory in appsync resolver #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! To document here, the docs show this is a required field but the resource specification shows not-required. |
davemasino
pushed a commit
to davemasino/troposphere
that referenced
this pull request
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppSync pipeline resolver docs specify that pipeline resolvers are not attached to any data source, I noticed my Cloudformation templates failing validation because of the non-allowed presence of "DataSourceName" in pipeline resolvers, so I changed the "DataSourceName" field in appsync.py to be be non-mandatory.
This is my first pull request, so please let me know if I've missed anything. I didn't open an issue because it seemed like a very small, self-contained fix.
Thanks for maintaining this project, it's been incredibly helpful!