Prefer awacs.aws.PolicyDocument over awacs.aws.Policy #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markpeek
reviewed
Jun 23, 2019
michael-k
force-pushed
the
awacs-aws-policydocument
branch
from
4b0f9af
to
ea5264d
Compare
`awacs.aws.PolicyDocument` was introduced in awacs 0.7.1 to prevent confusions with `troposphere.iam.Policy`. troposphere requires awacs >= 0.8. Examples should use `PolicyDocument` to let users start the right way. To not break existing code (`PolicyDocument` is a subclass of `Policy`), policytypes must include both if available.
michael-k
force-pushed
the
awacs-aws-policydocument
branch
from
ea5264d
to
881f3cb
Compare
|
Thanks @michael-k! |
davemasino
pushed a commit
to davemasino/troposphere
that referenced
this pull request
Oct 17, 2019
`awacs.aws.PolicyDocument` was introduced in awacs 0.7.1 to prevent confusions with `troposphere.iam.Policy`. troposphere requires awacs >= 0.8. Examples should use `PolicyDocument` to let users start the right way. To not break existing code (`PolicyDocument` is a subclass of `Policy`), policytypes must include both if available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
awacs.aws.PolicyDocumentwas introduced in awacs 0.7.1 to prevent confusions withtroposphere.iam.Policy. troposphere requires awacs >= 0.8.