Allow for AWSHelperFn objects in Tags #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnctitus
force-pushed
the
1385-conditional-tags
branch
from
283efce
to
dfa9875
Compare
|
@markpeek Any feedback on this PR? |
markpeek
reviewed
Jun 4, 2019
|
Thanks! |
davemasino
pushed a commit
to davemasino/troposphere
that referenced
this pull request
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1385
Usecase: We would like to add a dynamically named tag, depending on the value of a Stack parameter, for example if a string is provided, create a tag based on that value. Currently this is not possible.
This update allows for multiple args to be passed into the
Tagsconstructor, as long as all are either dictionaries, orAWSHelperFnobjects. It also adds aTagobject, to represent a single resource tag, and enforce proper formatting.