Fix bug where FilterGroups were required, when technically they are not #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug introduced here #1372 Basically while FilterGroups aren't required, the validate() function was effectively making them required. This makes it so validate only validates FilterGroups if they're actually set.
davemasino
pushed a commit
to davemasino/troposphere
that referenced
this pull request
Oct 17, 2019
…ot (cloudtools#1424) Fixes a bug introduced here cloudtools#1372 Basically while FilterGroups aren't required, the validate() function was effectively making them required. This makes it so validate only validates FilterGroups if they're actually set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced here #1372
Basically while FilterGroups aren't required, the validate() function
was effectively making them required. This makes it so validate only
validates FilterGroups if they're actually set.