Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tags to ECR Repository definition #1444

Merged
merged 2 commits into from
Jun 30, 2019

Conversation

patrickdean
Copy link
Contributor

ECR added support for tags back in December:
https://aws.amazon.com/about-aws/whats-new/2018/12/amazon-ecr-now-allows-repository-tagging/

Let me know if anything looks out of place. Thanks!

Copy link
Member

@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting a small tweak to this change. Thanks!

troposphere/ecr.py Outdated Show resolved Hide resolved
@markpeek markpeek merged commit 37643ec into cloudtools:master Jun 30, 2019
@markpeek
Copy link
Member

Thanks!

@patrickdean patrickdean deleted the add-tags-ecr branch July 3, 2019 13:37
davemasino pushed a commit to davemasino/troposphere that referenced this pull request Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants