Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding new Transfer properties, per 2020 Feb 13 update #1585

Merged
merged 1 commit into from Feb 22, 2020
Merged

adding new Transfer properties, per 2020 Feb 13 update #1585

merged 1 commit into from Feb 22, 2020

Conversation

axelpavageau
Copy link
Contributor

No description provided.

@otanner
Copy link

otanner commented Feb 20, 2020

Thanks for updating these. Should VpcEndpointId and VpcId be not required though as they are valid only if the EndpointType is set to a certain value and cannot both be set at the same time?

@axelpavageau
Copy link
Contributor Author

you're right, that was a mistake. Thanks for catching it !

@markpeek markpeek merged commit f1c9394 into cloudtools:master Feb 22, 2020
@markpeek
Copy link
Member

Thanks! And shoutout to @otanner for the review!

@axelpavageau axelpavageau deleted the feature/20200213-transfer branch June 10, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@axelpavageau @otanner @markpeek @axelpavageauekino