Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to acmpca #1660

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Fixes to acmpca #1660

merged 2 commits into from
Apr 24, 2020

Conversation

ntwaddell
Copy link
Contributor

@ntwaddell ntwaddell commented Apr 21, 2020 •
edited

Subject should be AWSProperty not AWSObject

aws-resource-acmpca-certificateauthority

Certificate should be AWSObject not AWSProperty

aws-resource-acmpca-certificate

@ntwaddell ntwaddell changed the title Fix acmpca Fix acmpca - Subject to AWSProperty Apr 22, 2020
@ntwaddell ntwaddell changed the title Fix acmpca - Subject to AWSProperty Fixes to acmpca Apr 22, 2020
@ntwaddell
Copy link
Contributor Author

One more update. Just tested locally, all seems to be working as expected now

@ntwaddell
Copy link
Contributor Author

@markpeek

@markpeek markpeek merged commit 42a2295 into cloudtools:master Apr 24, 2020
@markpeek
Copy link
Member

Thanks!

@ntwaddell
Copy link
Contributor Author

Thanks @markpeek 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ntwaddell @markpeek