AWS::MWAA Adding for managed airflow #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam133
changed the title
adam133
changed the title
|
Done |
|
Just wanted to share that using this PR locally I was able to create a cloudformation stack with a MWAA environment, so it seems like it works. Might be good to add more validation when I get time though. For example, the source bucket name has to start with |
|
Since this change was written for Python3 (str instead of basestring), I'll merge this in as part of the 3.0.0 release. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this issue: #1855
My first time contributing to this library, so I'm guessing I'm missing some things. But hopefully someone can use this as a starting point or at least check that I added things correctly!