[batch] Update required properties

[michael-k]

Some properties are no longer required (at least when using Fargate). Source:

• ContainerProperties.Memory: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-batch-jobdefinition-containerproperties.html#cfn-batch-jobdefinition-containerproperties-memory
• ContainerProperties.Vcpus: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-batch-jobdefinition-containerproperties.html#cfn-batch-jobdefinition-containerproperties-vcpus
• ComputeEnvironment.ServiceRole: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-batch-computeenvironment.html#cfn-batch-computeenvironment-servicerole

I've successfully deployed patched resources without those properties.

[markpeek]

Thanks!

[kumapo]

@markpeek Do you have any plans to include this patch into v2?

[michael-k]

@kumapo You can use patched versions in your code until you switch to v3:

from troposphere.batch import ComputeEnvironment, ContainerProperties


def _fix_required_props(parent, not_required):
    return {
        key: (value[0], False) if key in not_required else value
        for key, value in parent.props.items()
    }


class PatchedComputeEnvironment(ComputeEnvironment):
    props = _fix_required_props(ComputeEnvironment, not_required=["ServiceRole"])


class PatchedContainerProperties(ContainerProperties):
    props = _fix_required_props(ContainerProperties, not_required=["Memory", "Vcpus"])

PatchedComputeEnvironment and PatchedContainerProperties can be used anywhere where ComputeEnvironment/ContainerProperties can be used.

[kumapo]

@michael-k Thank you for your advice! I will try it.