Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new application loadbalancer objects and properties, following AWS announcement https://a… #544

Merged
merged 6 commits into from Aug 12, 2016

Conversation

axelpavageau
Copy link
Contributor

@philtay
Copy link
Contributor

philtay commented Aug 11, 2016

Please also add the TargetGroupARNs property to AWS::AutoScaling::AutoScalingGroup in order to complete this PR as per August 11, 2016 CloudFormation release. Thanks a lot!

@philtay
Copy link
Contributor

philtay commented Aug 11, 2016

Also note that I have created a separated module for AWS::ApplicationAutoScaling. I mean, now in troposphere we have both autoscaling and applicationautoscaling modules. This PR, instead, includes both AWS::ElasticLoadBalancingV2 and AWS::ElasticLoadBalancing in the same module. The natural name of the class for AWS::ElasticLoadBalancingV2::LoadBalancer would be LoadBalancer but you had to name it ApplicationLoadBalancer in order to avoid clashing with the already existing AWS::ElasticLoadBalancing::LoadBalancer. Basically I suggest to use separate modules for these resources too, but I think it's up to @markpeek to decide. I'm ready to merge autoscaling and applicationautoscaling if Mark wants me to.

@axelpavageau
Copy link
Contributor Author

You're right, it makes more sense to create a separate module. I hesitated between both options and went for a single module, but after a bit of sleep your way seems better.
The object's names will be more consistent with AWS'.
I'll correct my PR

@axelpavageau axelpavageau changed the title adding new objects and properties, followingAWS announcment https://a… adding new application loadbalancer objects and properties, following AWS announcement https://a… Aug 12, 2016
@philtay
Copy link
Contributor

philtay commented Aug 12, 2016

LGTM

@ntwaddell
Copy link
Contributor

Awesome, thanks for getting this added so quickly. :D

@markpeek markpeek merged commit d1da138 into cloudtools:master Aug 12, 2016
@markpeek
Copy link
Member

Thanks! Appreciate the rework and adding the example.

@mitesh9875
Copy link

Hi,
I have not get any example to setup application ELB, please share example for application loadbalancer.

@phobologic
Copy link
Member

@mitesh9875 The example troposphere code and the resulting cloudformation template are both included in this pull request. You can find them in the examples directory as well.

https://github.com/cloudtools/troposphere/blob/master/examples/ApplicationELB.py

amosshapira pushed a commit to amosshapira/troposphere that referenced this pull request Oct 24, 2016
… AWS announcement https://a… (cloudtools#544)

* adding new objects and properties, followingAWS announcment https://aws.amazon.com/blogs/aws/new-aws-application-load-balancer/

* moved application load balancer resources to a separate module, following discussion

* adding new property to AWS::AutoScaling::AutoScalingGroup tu allow targetting the new application load balancers

* adding some tests for the new application elb objects

* fixing inconsistent cloudformation output vs sample python code

* mixed some resources names
@axelpavageau axelpavageau deleted the application_elb branch November 20, 2018 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants