Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elasticache #592

Merged
merged 7 commits into from
Oct 13, 2016
Merged

Update elasticache #592

merged 7 commits into from
Oct 13, 2016

Conversation

magnusboman
Copy link
Contributor

No description provided.

Copy link
Member

@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just one minor change needed.

'SnapshotRetentionLimit': (integer, False),
'SnapshotWindow': (basestring, False),
'SnapshottingClusterId': (basestring, False),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change: move SnapshottingClusterId above SnapshotWindow.

@markpeek markpeek merged commit fb18f60 into cloudtools:master Oct 13, 2016
@markpeek
Copy link
Member

Excellent. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants