Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2 NoDevice should be type boolean not dict #858

Merged
merged 1 commit into from Oct 18, 2017
Merged

EC2 NoDevice should be type boolean not dict #858

merged 1 commit into from Oct 18, 2017

Conversation

tweakster
Copy link
Contributor

I've been trying to set NoDevice but am getting errors. Troposphere requires dict but I get a CF error "Value of property NoDevice must be of type String" when I use dict, even if a create an empty one.

http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/block-device-mapping-concepts.html

It looks like it always wants "" so I assume changing the type to basestring will enable this to work.

(Sorry I wasn't sure if I should have raised an issue first but just dived in :) )

@markpeek
Copy link
Member

Nice catch. However, according to the docs it should be a Boolean. Instead of basestring, can you try using boolean which should do the right thing.

@tweakster tweakster changed the title EC2 NoDevice should be type string not dict EC2 NoDevice should be type boolean not dict Oct 18, 2017
@tweakster
Copy link
Contributor Author

You are entirely correct that is my bad, sorry.

I did the decent thing and actually tested it this time. It works :o)

@markpeek markpeek merged commit 11b6ad6 into cloudtools:master Oct 18, 2017
@markpeek
Copy link
Member

Nice...thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants