[CLOUDTRUST-2375] Add middleware to enable feature according to reaml conf. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harture
reviewed
Mar 2, 2020
harture
approved these changes
Mar 4, 2020
| @@ -37,6 +38,50 @@ func MakeEndpointInstrumentingMW(m metrics.Metrics, histoName string) cs.Middlew | |||
| } | |||
| } | |||
|
|
|||
| // IDRetriever is an interface to get an ID using an object's name | |||
| type IDRetriever interface { | |||
There was a problem hiding this comment.
Why do we need this abstraction ?
There was a problem hiding this comment.
Why do we need this abstraction ?
Because implementation is done in keycloak-client and keycloak-client refers to common-service... So we should not add a reference to keycloak-client in this library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.