[CLOUDTRUST-2411] Add jenkinsfile, add sonarqube support #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fperot74
reviewed
Mar 11, 2020
| @@ -98,7 +98,7 @@ func TestValidateParameterNotNil(t *testing.T) { | |||
| t.Run("Not nil value", func(t *testing.T) { | |||
| assert.Nil(t, NewParameterValidator().ValidateParameterNotNil("param", t).Status()) | |||
| }) | |||
| t.Run("Nil interface{}", func(t *testing.T) { | |||
| t.Run("Nil interface", func(t *testing.T) { | |||
There was a problem hiding this comment.
No... it is really interface{}
There was a problem hiding this comment.
As discussed, this is a limitation of the sonar-scanner-cli tool. Without this fix I have:
11:04:35 ERROR: Error during SonarQube Scanner execution
11:04:35 java.util.regex.PatternSyntaxException: Illegal repetition near index 48
11:04:35 ^func\s+TestValidateParameterNotNil/Nil_interface{}\s*\(
As we both agreed, I've removed the incriminating '{}', and I've added a comment to explain my issue.
vloup
force-pushed
the
jenkins
branch
3 times, most recently
from
7065383
to
13559f0
Compare
fperot74
approved these changes
Mar 12, 2020
vloup
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.