Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudtrust 1771 fix unittest #128

Merged
merged 3 commits into from Oct 8, 2019
Merged

Cloudtrust 1771 fix unittest #128

merged 3 commits into from Oct 8, 2019

Conversation

harture
Copy link
Contributor

@harture harture commented Oct 8, 2019

One of the unittests was failing in our local CI.
I think Travis locale is UTC so it was not detected here.

@harture harture requested a review from fperot74 October 8, 2019 08:28
fperot74
fperot74 approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@fperot74 fperot74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like this... :-(

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1198

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 89.902%
Files with Coverage Reduction New Missed Lines %
pkg/event/component.go 1 95.96%
Totals Coverage Status
Change from base Build 1196: 0.0%
Covered Lines: 2751
Relevant Lines: 3060
💛 - Coveralls

@harture
Copy link
Contributor Author

harture commented Oct 8, 2019

J'aime pas non plus :(

@harture harture merged commit 32175f6 into master Oct 8, 2019
@fperot74 fperot74 deleted the CLOUDTRUST-1771_FixUnittest branch October 29, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fperot74 fperot74 fperot74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harture @coveralls @fperot74