Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDTRUST-1752] correcting the error format + logging errors #136

Merged
merged 2 commits into from Oct 28, 2019
Merged

[CLOUDTRUST-1752] correcting the error format + logging errors #136

merged 2 commits into from Oct 28, 2019

Conversation

bsoniam
Copy link
Contributor

@bsoniam bsoniam commented Oct 25, 2019

No description provided.

@coveralls
Copy link

coveralls commented Oct 25, 2019 •
edited

Pull Request Test Coverage Report for Build 1293

  • 52 of 67 (77.61%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 91.78%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/account/endpoint.go 1 2 50.0%
internal/keycloakb/logging.go 0 14 0.0%
Totals Coverage Status
Change from base Build 1266: 0.2%
Covered Lines: 2970
Relevant Lines: 3236
💛 - Coveralls

harture
harture requested changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@harture harture left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add an event for DeleteAccount method, it seems I missed it.
Maybe we could create a method for reportEvent as we are using it 4 times and code seems very similar ?

fperot74
fperot74 approved these changes Oct 28, 2019
View reviewed changes
pkg/account/component.go Outdated Show resolved Hide resolved
harture
harture reviewed Oct 28, 2019
View reviewed changes
pkg/account/component.go Outdated Show resolved Hide resolved
@bsoniam bsoniam merged commit e068bd3 into master Oct 28, 2019
@fperot74 fperot74 deleted the jira-1752 branch October 29, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harture harture harture approved these changes

@fperot74 fperot74 fperot74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bsoniam @coveralls @harture @fperot74