Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDTRUST-2294] Add endpoint to manage back-office configuration #188

Merged
merged 1 commit into from
Mar 3, 2020
Merged

[CLOUDTRUST-2294] Add endpoint to manage back-office configuration #188

merged 1 commit into from
Mar 3, 2020

Conversation

fperot74
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 25, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1899

  • 190 of 219 (86.76%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.658%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/management/endpoint.go 14 26 53.85%
pkg/management/component.go 73 90 81.11%
Totals Coverage Status
Change from base Build 1897: 0.05%
Covered Lines: 5065
Relevant Lines: 5526
💛 - Coveralls

@fperot74 fperot74 force-pushed the ct-2294 branch 2 times, most recently from 463df0c to 6fa481a Compare February 25, 2020 15:06
bsoniam
bsoniam reviewed Feb 26, 2020
View reviewed changes
api/management/api.go Outdated Show resolved Hide resolved
harture
harture reviewed Feb 27, 2020
View reviewed changes
internal/keycloakb/configdbmodule.go Outdated Show resolved Hide resolved
pkg/management/authorization.go Outdated Show resolved Hide resolved
pkg/management/authorization.go Outdated Show resolved Hide resolved
pkg/management/authorization.go Outdated Show resolved Hide resolved
fratt-elca
fratt-elca approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@fratt-elca fratt-elca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected! Please merge.

@fperot74 fperot74 merged commit 039b8a9 into cloudtrust:master Mar 3, 2020
@fperot74 fperot74 deleted the ct-2294 branch March 4, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsoniam bsoniam bsoniam approved these changes

@fratt-elca fratt-elca fratt-elca approved these changes

@harture harture Awaiting requested review from harture

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fperot74 @coveralls @harture @bsoniam @fratt-elca