Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDTRUST-2314] Fix birthDate attribute format #189

Merged
merged 2 commits into from
Mar 4, 2020
Merged

[CLOUDTRUST-2314] Fix birthDate attribute format #189

merged 2 commits into from
Mar 4, 2020

Conversation

fperot74
Copy link
Contributor

@fperot74 fperot74 commented Feb 26, 2020 •
edited

@fperot74 fperot74 changed the title [CLOUDTRUST-2314] Fix birthDate attribute format. Attributes manageme… [CLOUDTRUST-2314] Fix birthDate attribute format Feb 26, 2020
@coveralls
Copy link

coveralls commented Feb 27, 2020 •
edited

Pull Request Test Coverage Report for Build 1915

  • 117 of 118 (99.15%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 91.589%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/management/component.go 9 10 90.0%
Totals Coverage Status
Change from base Build 1905: -0.07%
Covered Lines: 5009
Relevant Lines: 5469
💛 - Coveralls

harture
harture approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@harture harture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except, I think the attributes key should be part of keycloak-bridge/common but not being part og keycloak-client

@fperot74 fperot74 force-pushed the ct-2314 branch 4 times, most recently from 816af72 to a22c8fc Compare March 3, 2020 09:24
@fperot74 fperot74 merged commit 2a05777 into cloudtrust:master Mar 4, 2020
@fperot74 fperot74 deleted the ct-2314 branch March 4, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harture harture harture approved these changes

@bsoniam bsoniam Awaiting requested review from bsoniam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fperot74 @coveralls @harture