Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute actions email #29

Merged
merged 5 commits into from Apr 18, 2019
Merged

Execute actions email #29

merged 5 commits into from Apr 18, 2019

Conversation

harture
Copy link
Contributor

@harture harture commented Apr 18, 2019

No description provided.

@harture harture requested a review from fperot74 April 18, 2019 12:53
@fperot74 fperot74 mentioned this pull request Apr 18, 2019
@coveralls
Copy link

coveralls commented Apr 18, 2019

Pull Request Test Coverage Report for Build 330

  • 36 of 36 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 93.018%

Totals Coverage Status
Change from base Build 326: 0.09%
Covered Lines: 2105
Relevant Lines: 2263

💛 - Coveralls

@@ -403,6 +403,54 @@ paths:
responses:
200:
description: successful operation
/realms/{realm}/users/{userID}/execute-actions-email:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With REST, we should use plural nouns.
PUT /realms/{realm}/users/{userID}/emails/actions would be more RESTful

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

execute-actions-email is coming from Keycloak REST API, maybe not a very good reason ;)
/actions would not be enough expressive in my opinion.
As we already have /send-verify-email it is at least coherent.

@harture harture merged commit b33e120 into master Apr 18, 2019
@harture harture deleted the execute-actions-email-rpo branch April 25, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants