[CLOUDTRUST-1262] Get groups #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 712
💛 - Coveralls |
bsoniam
requested review from
fperot74 and
harture
and removed request for
fperot74
fperot74
approved these changes
May 27, 2019
harture
requested changes
May 27, 2019
cmd/keycloakb/keycloak_bridge.go
Outdated
| @@ -594,6 +597,9 @@ func main() { | |||
| managementSubroute.Path("/realms/{realm}/clients/{clientID}/roles").Methods("GET").Handler(getClientRolesHandler) | |||
| managementSubroute.Path("/realms/{realm}/clients/{clientID}/roles").Methods("POST").Handler(createClientRolesHandler) | |||
|
|
|||
| //groups | |||
| managementSubroute.Path("/realms/{realm:[a-zA-Z0-9_-]+}/groups").Methods("GET").Handler(getGroupsHandler) | |||
There was a problem hiding this comment.
the regexp is not needed anymore here. We manage it in http.go
| @@ -119,6 +129,16 @@ | |||
| "master": { | |||
| "integrator_agent": {} | |||
| }, | |||
| "GetGroups": { | |||
| "master": { | |||
There was a problem hiding this comment.
I think DEP should also be added
| } | ||
| }, | ||
| "GetRoles": { | ||
| "master": { |
configs/authorization.json
Outdated
| @@ -245,6 +265,16 @@ | |||
| "*": {} | |||
| } | |||
| }, | |||
| "GetGroups": { | |||
| "master": { | |||
There was a problem hiding this comment.
should be DEP instead of master
configs/authorization.json
Outdated
| } | ||
| }, | ||
| "GetRoles": { | ||
| "master": { |
There was a problem hiding this comment.
should be DEP instead of master
harture
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added get groups endpoint
Added authorization for GetRoles: anyone can query and get the roles of his realm