Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit events #76

Merged
merged 14 commits into from
Jun 6, 2019
Merged

Audit events #76

merged 14 commits into from
Jun 6, 2019

Conversation

bsoniam
Copy link
Contributor

@bsoniam bsoniam commented Jun 3, 2019

GET_ACTIVITY: the agent gets the activity events of an account
SMS_CHALLENGE: the agent sends a code by SMS on the subscriber's phone to check his identity

@bsoniam bsoniam requested review from harture and fperot74 and removed request for harture June 3, 2019 12:06
@coveralls
Copy link

coveralls commented Jun 3, 2019

Pull Request Test Coverage Report for Build 734

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 93.745%

Totals Coverage Status
Change from base Build 730: 0.02%
Covered Lines: 2158
Relevant Lines: 2302

💛 - Coveralls

@bsoniam bsoniam self-assigned this Jun 3, 2019
@bsoniam bsoniam requested a review from harture June 3, 2019 16:32
Copy link
Contributor

@harture harture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems wired, as if there is a mix with a commit related to groups. Need to be checked

@@ -31,6 +31,16 @@
"*": {}
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seems wired. Something seems wrong here

@@ -553,6 +559,9 @@ func main() {
managementSubroute.Path("/realms/{realm}/clients/{clientID}/roles").Methods("GET").Handler(getClientRolesHandler)
managementSubroute.Path("/realms/{realm}/clients/{clientID}/roles").Methods("POST").Handler(createClientRolesHandler)

//groups
managementSubroute.Path("/realms/{realm}/groups").Methods("GET").Handler(getGroupsHandler)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems not related to this commit but a previous one. Strange ....

@harture harture self-requested a review June 6, 2019 07:26
@harture harture merged commit f948a9b into master Jun 6, 2019
@harture harture deleted the audit-events branch October 28, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants