Init pwd #88
Init pwd #88
Conversation
Pull Request Test Coverage Report for Build 842
💛 - Coveralls |
pkg/management/component.go
Outdated
| @@ -490,9 +490,14 @@ func (c *component) ExecuteActionsEmail(ctx context.Context, realmName string, u | |||
| var accessToken = ctx.Value(cs.CtContextAccessToken).(string) | |||
|
|
|||
| var actions = []string{} | |||
| var init_password_action = "sms-password-set" | |||
There was a problem hiding this comment.
You might have a go-lint recommandation asking not to use underscore in variable names. initPasswordAction would be more Go-compliant
There was a problem hiding this comment.
Hahaha, only now I noticed how I named this variable (Friday tiredness) :))).
Thanks, good point.
pkg/management/component.go
Outdated
| @@ -474,8 +474,8 @@ func (c *component) ResetPassword(ctx context.Context, realmName string, userID | |||
| } | |||
|
|
|||
| //store the API call into the DB | |||
| // the error should be treated | |||
| _ = c.reportEvent(ctx, "INIT_PASSWORD", database.CtEventRealmName, realmName, database.CtEventUserID, userID) | |||
| //_ = c.reportEvent(ctx, "INIT_PASSWORD", database.CtEventRealmName, realmName, database.CtEventUserID, userID) | |||
There was a problem hiding this comment.
If not used, you'd better completely remove this block
There was a problem hiding this comment.
I would prefer to leave it as I don't know if the back office will start using it or not soon
There was a problem hiding this comment.
If we decide to leave the functionality, I would suggest to also leave the reportEvent.
pkg/management/component_test.go
Outdated
| @@ -1281,8 +1281,8 @@ func TestExecuteActionsEmail(t *testing.T) { | |||
| var accessToken = "TOKEN==" | |||
| var realmName = "master" | |||
| var userID = "1245-7854-8963" | |||
| var reqActions = []api.RequiredAction{"action1", "action2"} | |||
| var actions = []string{"action1", "action2"} | |||
| var reqActions = []api.RequiredAction{"sms-password-set", "action1", "action2"} | |||
There was a problem hiding this comment.
If you move init_password_action declaration in a const (...) block at the beginning of component.go, you could reuse it here and prevent potential mis-spelling.
pkg/management/component.go
Outdated
| @@ -474,8 +474,8 @@ func (c *component) ResetPassword(ctx context.Context, realmName string, userID | |||
| } | |||
|
|
|||
| //store the API call into the DB | |||
| // the error should be treated | |||
| _ = c.reportEvent(ctx, "INIT_PASSWORD", database.CtEventRealmName, realmName, database.CtEventUserID, userID) | |||
| //_ = c.reportEvent(ctx, "INIT_PASSWORD", database.CtEventRealmName, realmName, database.CtEventUserID, userID) | |||
There was a problem hiding this comment.
If we decide to leave the functionality, I would suggest to also leave the reportEvent.
added INIT_PASSWORD event when a support user calls the API execute-actions-email with the action sms-password-set