Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime metrics #449

Closed
p-kozlowski opened this issue Apr 25, 2017 · 2 comments
Closed

Runtime metrics #449

p-kozlowski opened this issue Apr 25, 2017 · 2 comments
Labels
enhancement

Comments

@p-kozlowski
Copy link
Contributor

I'd like to expose runtime metrics, like number of requests processed per second or min/max/avg request processing time. I was thinking of using https://github.com/rcrowley/go-metrics. This way Gohan could be easily integrated with monitoring frameworks like Graphite/Prometheus/ELK.

@nati, @astralblue, @marcin-ptaszynski, @przemyslaw-dobrowolski-cl what do you think about it?
@marcin-ptaszynski
Copy link
Contributor

Looks abstracted enough, that it can be used in generic layer and be fully configurable.

nati added a commit that referenced this issue Jun 12, 2017
@nati
Merge pull request #464 from p-kozlowski/runtime-metrics
879beac 
[ESI-12650] Runtime metrics (issue #449)
@p-kozlowski p-kozlowski reopened this Jul 11, 2017
@p-kozlowski
Copy link
Contributor Author

Done in #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcin-ptaszynski @p-kozlowski