Add support for custom actions in client #283
Conversation
|
@abonie , I think you should update document additional client commands here https://github.com/cloudwan/gohan/blob/master/docs/source/commands.rst#command |
| if _, ok := commonParams[key]; !ok { | ||
| return nil, fmt.Errorf("Error parsing parameter %s", key) | ||
| } | ||
| value := args[i+1] |
There was a problem hiding this comment.
isn't it going to crash if we pass odd number of arguments, like gohan client action --opt1 value1 --opt2?
EDIT: oh, I see, splitArgs ensures that arg number is even before this function is called.
abonie
force-pushed
the
support_custom_actions_in_client
branch
from
8f3e59c
to
0ea953e
Compare
| Custom commands | ||
| --------------- | ||
|
|
||
| Custom commands, if specified in schema, are also supported by gohan client and should be invoked as follows: |
There was a problem hiding this comment.
there is no reference to Actions.
There was a problem hiding this comment.
I don't get it. Unless you mean, that it should say "Custom actions" instead of "Custom commands"?
There was a problem hiding this comment.
Exactly that. user may not know that custom commands are generated from Custom Actions defined in https://github.com/cloudwan/gohan/blob/master/docs/source/schema.rst#custom-actions-schema
abonie
force-pushed
the
support_custom_actions_in_client
branch
from
0ce5016
to
f95794d
Compare
| Custom commands | ||
| --------------- | ||
|
|
||
| Any `custom actions <./schema.rst/#custom-actions-schema>`_ specified in schema are also supported as commands by gohan client and should be invoked as follows: |
There was a problem hiding this comment.
I don't really know anything about creating docs from .rst format, so someone should please verify, that this link doesn't break
There was a problem hiding this comment.
You can easily verify it with:
sudo pip install sphinx
cd ./docs
make html
Results can be found in build directory.
abonie
force-pushed
the
support_custom_actions_in_client
branch
2 times, most recently
from
84c57ce
to
519dfd7
Compare
Gohan client will parse custom actions defined in schema and support them in CLI.
abonie
force-pushed
the
support_custom_actions_in_client
branch
from
519dfd7
to
e991383
Compare
Issue #257
Gohan client will parse custom actions defined in schema
and support them in CLI.