generated from cloudwego/.github
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(generic-call-example): open payment platform #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baiyutang
changed the title
WIP:feat(generic-call-example): open payment platform
feat(generic-call-example): open payment platform
Nov 30, 2022
Please try to fix the CI. E.g. Copyright Header should be added for necessary files. |
Copyright will be added this tonight |
GuangmingLuo
reviewed
Dec 1, 2022
GuangmingLuo
reviewed
Dec 2, 2022
GuangmingLuo
reviewed
Dec 2, 2022
GuangmingLuo
reviewed
Dec 2, 2022
GuangmingLuo
reviewed
Dec 2, 2022
CoderPoet
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@baiyutang 可以给所有的公共函数加一下注释吗?生成的代码除外 |
li-jin-gou
requested changes
Dec 6, 2022
open-payment-platform/hertz-gateway/biz/middleware/gateway_auth.go
Outdated
Show resolved
Hide resolved
GuangmingLuo
approved these changes
Dec 9, 2022
li-jin-gou
approved these changes
Dec 9, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
What this PR does / why we need it (en: English/zh: Chinese):
en: open payment platform example using generic call
zh: 使用泛化调用的支付开放平台示例
Which issue(s) this PR fixes:
Description
整体思路是 hertz 做网关分发请求,根据 query 路径判断服务,post.method 字段判断需要请求的服务接口,最后把对应接口的 biz_params 一下子给过去。