Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add easy-note #13

Merged
merged 13 commits into from
Dec 27, 2022
Merged

feat: add easy-note #13

merged 13 commits into from
Dec 27, 2022

Conversation

justlorain
Copy link
Member

@justlorain justlorain commented Dec 3, 2022 •
edited

What type of PR is this?

feat: A new feature

What this PR does / why we need it (en: English/zh: Chinese):

en: migrate easy-note, complete following optimizations
zh: 迁移easy-note，完成以下优化

  • only use thrift
  • use hz and more hertz feature (BindAndValidate, requestid, gzip, pprof)
  • use gorm transaction and more gorm feature
  • use otel, logrus (gorm/kitex/hertz)
  • remove unnecessary kitex feature
  • refine the code structure
  • use thrift-gen-validator

Which issue(s) this PR fixes:

Fixes #11

@li-jin-gou
Copy link
Member

CI need to solve.

li-jin-gou
li-jin-gou requested changes Dec 4, 2022
View reviewed changes
easy-note/pkg/errno/errno.go Outdated Show resolved Hide resolved
easy-note/cmd/api/rpc/note.go Outdated Show resolved Hide resolved
easy-note/cmd/user/dal/db/init.go Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou requested changes Dec 4, 2022
View reviewed changes
easy-note/cmd/api/.hz Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou requested changes Dec 4, 2022
View reviewed changes
easy-note/idl/user.thrift Outdated Show resolved Hide resolved
easy-note/cmd/api/router.go Outdated Show resolved Hide resolved
easy-note/cmd/api/router.go Outdated Show resolved Hide resolved
easy-note/cmd/api/main.go Outdated Show resolved Hide resolved
easy-note/cmd/api/main.go Outdated Show resolved Hide resolved
easy-note/cmd/api/handler/user_service.go Outdated Show resolved Hide resolved
easy-note/cmd/note/handler.go Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou requested changes Dec 4, 2022
View reviewed changes
Copy link
Member

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a detailed description to help code CR.

@justlorain justlorain changed the title [WIP] add easy-note feat: add easy-note Dec 21, 2022
GuangmingLuo
GuangmingLuo reviewed Dec 23, 2022
View reviewed changes
easy_note/README.md Outdated Show resolved Hide resolved
GuangmingLuo
GuangmingLuo reviewed Dec 23, 2022
View reviewed changes
easy_note/go.mod Outdated Show resolved Hide resolved
@GuangmingLuo
Copy link
Member

@justlorain 项目根目录在补充一段文档，参考其它子项目

@justlorain
Copy link
Member Author

@justlorain 项目根目录在补充一段文档，参考其它子项目

已添加，thx

@li-jin-gou
Copy link
Member

LGTM

@li-jin-gou li-jin-gou merged commit 84c0e4f into cloudwego:main Dec 27, 2022
@justlorain justlorain mentioned this pull request Jan 31, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuangmingLuo GuangmingLuo GuangmingLuo left review comments

@li-jin-gou li-jin-gou li-jin-gou approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Complete the easy_note todo list
3 participants
@justlorain @li-jin-gou @GuangmingLuo