docs: restructure /docs/hertz/reference/json.md #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Haswf
changed the title
Haswf
changed the title
|
@AsterDY Would you like to review this change as you seem to add these doc in the first place? Many thanks |
AsterDY
reviewed
Jul 21, 2022
|
Hi, @AsterDY. I've adjust content in accordance with your feedback. Let's like we are good to go! |
GuangmingLuo
approved these changes
Jul 22, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR changed the layout of json.md in both zh and en, specificlly it introduces sonic first, then inform how sonic differs from
encoding/jsonin terms of behaviour. Lastly, it covers how to BYO json marshall implemenation. I believe it will help user to navigate and find what they need easier.What this PR does / why we need it (en: English/zh: Chinese):
en: restructure json.md
zh: 调整 json.md 结构
Which issue(s) this PR fixes:
Fixes #234