docs: improve middleware overview #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rogerogers <rogers@rogerogers.com>
FGYFFFF
reviewed
Oct 17, 2022
content/en/docs/hertz/tutorials/basic-feature/middleware/_index.md
Outdated
Show resolved
Hide resolved
FGYFFFF
reviewed
Oct 17, 2022
|
|
||
| ```go | ||
| // One way | ||
| func MyMiddleware() app.HandlerFunc { | ||
| return func(ctx context.Context, c *app.RequestContext) { | ||
| // pre-handle | ||
| ... | ||
| // ... | ||
| c.Next(ctx) |
There was a problem hiding this comment.
这块是可以加一句，if there is no 'post-handle' logic, the 'c.Next(ctx)' can be omitted.
There was a problem hiding this comment.
.Next能否忽略的不是说是否存在后处理逻辑，而是后续是否需要保证该中间件和业务handler在一条函数调用栈上；类似panic recovery这种就是没有后处理逻辑，但.Next却必须保留的原因如此
FGYFFFF
reviewed
Oct 17, 2022
content/zh/docs/hertz/tutorials/basic-feature/middleware/_index.md
Outdated
Show resolved
Hide resolved
FGYFFFF
reviewed
Oct 17, 2022
content/zh/docs/hertz/tutorials/basic-feature/middleware/_index.md
Outdated
Show resolved
Hide resolved
FGYFFFF
reviewed
Oct 17, 2022
content/zh/docs/hertz/tutorials/basic-feature/middleware/_index.md
Outdated
Show resolved
Hide resolved
FGYFFFF
reviewed
Oct 17, 2022
content/zh/docs/hertz/tutorials/basic-feature/middleware/_index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: rogerogers <rogers@rogerogers.com>
|
done |
FGYFFFF
approved these changes
Nov 4, 2022
GuangmingLuo
approved these changes
Nov 7, 2022
YUandJIANG
pushed a commit
to YUandJIANG/cloudwego.github.io
that referenced
this pull request
Nov 10, 2022
* docs: improve middleware overview Signed-off-by: rogerogers <rogers@rogerogers.com> * docs: middleware cr fix Signed-off-by: rogerogers <rogers@rogerogers.com> Signed-off-by: rogerogers <rogers@rogerogers.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rogerogers rogers@rogerogers.com
What type of PR is this?
docs: improve middleware overview
What this PR does / why we need it (en: English/zh: Chinese):
en: improve middleware overview doc
zh: 优化中间件概览文档
Which issue(s) this PR fixes: