Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(hertz): add response writer ext doc #569

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

a631807682
Copy link
Member

What type of PR is this?

What this PR does / why we need it (en: English/zh: Chinese):

en: add en docs for response writer ext
zh: 添加response writer扩展的英文文档

Which issue(s) this PR fixes:

related to cloudwego/hertz#656

@a631807682 a631807682 requested review from a team as code owners March 10, 2023 07:13
@GuangmingLuo
Copy link
Member

Thanks for your contribution. Can you add the zh version of this doc in the same PR ? @a631807682

@a631807682
Copy link
Member Author

Thanks for your contribution. Can you add the zh version of this doc in the same PR ? @a631807682

I will add zh doc later

@GuangmingLuo GuangmingLuo changed the title doc(hertz): add response writer ext doc WIP: doc(hertz): add response writer ext doc Mar 10, 2023
@GuangmingLuo GuangmingLuo changed the title WIP: doc(hertz): add response writer ext doc doc(hertz): add response writer ext doc Mar 10, 2023
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@GuangmingLuo GuangmingLuo merged commit 0a91fc1 into cloudwego:main Mar 14, 2023
@a631807682 a631807682 deleted the doc_response_writer branch March 14, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants