Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add documentation for required parameter #592

Merged
merged 4 commits into from
Mar 31, 2023

Conversation

Haswf
Copy link
Contributor

@Haswf Haswf commented Mar 28, 2023

What type of PR is this?

This commit adds documentation for required parameter in Binding and validate.
Required paramter is a important binding feature but it's missing in documentation.

What this PR does / why we need it (en: English/zh: Chinese):

en: add documentation for required parameter
zh: 补充必填参数文档

Which issue(s) this PR fixes:

@Haswf Haswf requested review from a team as code owners March 28, 2023 16:00
@Haswf
Copy link
Contributor Author

Haswf commented Mar 28, 2023

Hey @FGYFFFF, we just discuessed how this features works recently. Could you review the changes?

@Haswf Haswf requested a review from GuangmingLuo March 30, 2023 02:52
@GuangmingLuo
Copy link
Member

@FGYFFFF please confirm this.

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2023

CLA assistant check
All committers have signed the CLA.

@Haswf Haswf requested a review from FGYFFFF March 31, 2023 04:49
Copy link
Contributor

@FGYFFFF FGYFFFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~~~ thanks

@GuangmingLuo GuangmingLuo merged commit 8cabc15 into cloudwego:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants