-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update validator.md in en/zh tutorial docs #593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please sign the CLA. |
HeyJavaBean
previously approved these changes
Mar 30, 2023
rogerogers
reviewed
Mar 30, 2023
这篇文档从概述、安装、使用,都应该是二级标题,麻烦统一修改下吧,谢谢~ |
Done, 修改了标题和子标题 |
GuangmingLuo
previously approved these changes
Apr 4, 2023
GuangmingLuo
reviewed
Apr 4, 2023
HeyJavaBean
reviewed
Apr 4, 2023
rogerogers
reviewed
Apr 4, 2023
rogerogers
reviewed
Apr 4, 2023
rogerogers
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GuangmingLuo
approved these changes
Apr 6, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
docs: add
installation
part in kitex/tutorials/code-gen/validator with en/zh docsWhat this PR does / why we need it (en: English/zh: Chinese):
en: update validator doc with installation
zh: 在 validator 文档中增加安装说明
Which issue(s) this PR fixes:
Fix #586