Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update validator.md in en/zh tutorial docs #593

Merged
merged 5 commits into from
Apr 6, 2023

Conversation

CarlCao17
Copy link
Contributor

What type of PR is this?

docs: add installation part in kitex/tutorials/code-gen/validator with en/zh docs

What this PR does / why we need it (en: English/zh: Chinese):

en: update validator doc with installation
zh: 在 validator 文档中增加安装说明

Which issue(s) this PR fixes:

Fix #586

@CarlCao17 CarlCao17 requested review from a team as code owners March 29, 2023 16:55
@CLAassistant
Copy link

CLAassistant commented Mar 29, 2023

CLA assistant check
All committers have signed the CLA.

@rogerogers
Copy link
Contributor

Please sign the CLA.

HeyJavaBean
HeyJavaBean previously approved these changes Mar 30, 2023
@GuangmingLuo
Copy link
Member

这篇文档从概述、安装、使用,都应该是二级标题,麻烦统一修改下吧,谢谢~

@CarlCao17
Copy link
Contributor Author

这篇文档从概述、安装、使用,都应该是二级标题,麻烦统一修改下吧,谢谢~

Done, 修改了标题和子标题

GuangmingLuo
GuangmingLuo previously approved these changes Apr 4, 2023
@GuangmingLuo GuangmingLuo self-requested a review April 4, 2023 10:00
Copy link
Contributor

@rogerogers rogerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuangmingLuo GuangmingLuo merged commit 5814156 into cloudwego:main Apr 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Thrift Validator:文档中未提示需要额外安装 github.com/cloudwego/thrift-gen-validator
5 participants