-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(hertz):update the tutorial documentation of the logger component #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuangmingLuo
reviewed
Apr 4, 2023
GuangmingLuo
reviewed
Apr 4, 2023
GuangmingLuo
reviewed
Apr 4, 2023
参考其它 PR 优化下 PR title |
ViolaPioggia
changed the title
Logger doc
doc(hertz):update the tutorial documentation of the logger component
Apr 4, 2023
rogerogers
reviewed
Apr 5, 2023
GuangmingLuo
reviewed
Apr 6, 2023
GuangmingLuo
reviewed
Apr 6, 2023
GuangmingLuo
reviewed
Apr 7, 2023
GuangmingLuo
reviewed
Apr 7, 2023
GuangmingLuo
reviewed
Apr 7, 2023
li-jin-gou
reviewed
Apr 7, 2023
li-jin-gou
requested changes
Apr 7, 2023
li-jin-gou
requested changes
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI 的问题需要修复,结构看起来没什么问题,另外则是评论由提出的人 resolve 。
I will CR it today and can resolve a code conflict @ViolaPioggia ❤️ |
li-jin-gou
changed the title
[WIP]doc(hertz):update the tutorial documentation of the logger component
doc(hertz):update the tutorial documentation of the logger component
Apr 28, 2023
li-jin-gou
previously approved these changes
Apr 28, 2023
看了一下没啥问题了,大家可以再 review 一下 cc @GuangmingLuo @rogerogers @welkeyever |
rogerogers
reviewed
Apr 28, 2023
Signed-off-by: rogrogers <rogers@rogerogers.com>
li-jin-gou
approved these changes
May 4, 2023
rogerogers
approved these changes
May 4, 2023
GuangmingLuo
reviewed
May 4, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
docs
What this PR does / why we need it (en: English/zh: Chinese):
en: Enriched the tutorial documentation of the logger component under the hertz framework
zh:丰富了hertz框架下logger组件的教程文档
Which issue(s) this PR fixes:
Fixes #<488>