Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(hertz):update the tutorial documentation of the logger component #595

Merged
merged 27 commits into from
May 4, 2023

Conversation

ViolaPioggia
Copy link
Member

What type of PR is this?

docs

What this PR does / why we need it (en: English/zh: Chinese):

en: Enriched the tutorial documentation of the logger component under the hertz framework
zh:丰富了hertz框架下logger组件的教程文档

Which issue(s) this PR fixes:

Fixes #<488>

@ViolaPioggia ViolaPioggia requested review from a team as code owners April 3, 2023 13:34
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2023

CLA assistant check
All committers have signed the CLA.

@GuangmingLuo
Copy link
Member

参考其它 PR 优化下 PR title

@ViolaPioggia ViolaPioggia changed the title Logger doc doc(hertz):update the tutorial documentation of the logger component Apr 4, 2023
Copy link
Member

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI 的问题需要修复,结构看起来没什么问题,另外则是评论由提出的人 resolve 。

@li-jin-gou
Copy link
Member

I will CR it today and can resolve a code conflict @ViolaPioggia ❤️

@li-jin-gou li-jin-gou changed the title [WIP]doc(hertz):update the tutorial documentation of the logger component doc(hertz):update the tutorial documentation of the logger component Apr 28, 2023
li-jin-gou
li-jin-gou previously approved these changes Apr 28, 2023
@li-jin-gou
Copy link
Member

li-jin-gou commented Apr 28, 2023

看了一下没啥问题了,大家可以再 review 一下 cc @GuangmingLuo @rogerogers @welkeyever

Signed-off-by: rogrogers <rogers@rogerogers.com>
@welkeyever welkeyever merged commit 3debec6 into cloudwego:main May 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

docs: optimize logger doc
6 participants