-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(hertz): update service discovery doc #623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d04cdf.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thanks |
rogerogers
requested changes
Apr 24, 2023
content/en/docs/hertz/tutorials/service-governance/service_discovery/etcd.md
Outdated
Show resolved
Hide resolved
rogerogers
reviewed
Apr 24, 2023
content/en/docs/hertz/tutorials/service-governance/service_discovery/redis.md
Outdated
Show resolved
Hide resolved
content/en/docs/hertz/tutorials/service-governance/service_discovery/zookeeper.md
Show resolved
Hide resolved
貌似只有consul是newRegister其他都是newRegistry |
li-jin-gou
reviewed
May 4, 2023
content/zh/docs/hertz/tutorials/service-governance/service_discovery/_index.md
Outdated
Show resolved
Hide resolved
li-jin-gou
reviewed
May 4, 2023
content/zh/docs/hertz/tutorials/service-governance/service_discovery/nacos.md
Outdated
Show resolved
Hide resolved
li-jin-gou
reviewed
May 4, 2023
content/zh/docs/hertz/tutorials/service-governance/service_discovery/consul.md
Outdated
Show resolved
Hide resolved
li-jin-gou
reviewed
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
英文的问题同上
This reverts commit 4d04cdf.
看了一下没啥问题了,大家可以再 review 一下 cc @GuangmingLuo @rogerogers @welkeyever |
li-jin-gou
previously approved these changes
May 5, 2023
welkeyever
reviewed
May 5, 2023
content/zh/docs/hertz/tutorials/service-governance/service_discovery/_index.md
Outdated
Show resolved
Hide resolved
welkeyever
approved these changes
May 5, 2023
rogerogers
approved these changes
May 5, 2023
li-jin-gou
approved these changes
May 5, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
doc
Check the PR title.
(Optional) Translate the PR title into Chinese.
更新服务发现文档
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: update the service discovery doc and correct some mistakes
zh(optional): 更新服务发现文档,并改正了一些问题