Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(hertz): update service discovery doc #623

Merged
merged 39 commits into from
May 5, 2023
Merged

Conversation

MulL1on
Copy link
Contributor

@MulL1on MulL1on commented Apr 22, 2023

What type of PR is this?

doc

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

更新服务发现文档

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: update the service discovery doc and correct some mistakes
zh(optional): 更新服务发现文档,并改正了一些问题

@MulL1on MulL1on requested review from a team as code owners April 22, 2023 16:11
@vercel
Copy link

vercel bot commented Apr 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloudwego ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 11:58am

@li-jin-gou
Copy link
Member

thanks

@rogerogers rogerogers self-requested a review April 24, 2023 05:53
@rogerogers
Copy link
Contributor

貌似只有consul是newRegister其他都是newRegistry

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文的问题同上

@li-jin-gou
Copy link
Member

看了一下没啥问题了,大家可以再 review 一下 cc @GuangmingLuo @rogerogers @welkeyever

li-jin-gou
li-jin-gou previously approved these changes May 5, 2023
@li-jin-gou li-jin-gou merged commit 2554cac into cloudwego:main May 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

7 participants