Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add render docs #662

Merged
merged 17 commits into from
Jun 8, 2023
Merged

docs: add render docs #662

merged 17 commits into from
Jun 8, 2023

Conversation

Hanser001
Copy link
Contributor

What type of PR is this?

docs

(Optional) Translate the PR title into Chinese.

增加render文档

@Hanser001 Hanser001 requested review from a team as code owners May 25, 2023 12:28
@vercel
Copy link

vercel bot commented May 25, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloudwego ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 3:28am

@CLAassistant
Copy link

CLAassistant commented May 25, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@GuangmingLuo
Copy link
Member

文档缺少 header 文件，参考其它文档补充下吧，注意 weight 设置

rogerogers
rogerogers reviewed May 29, 2023
View reviewed changes
Copy link
Contributor

@rogerogers rogerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中文的单词适当增加点空格吧，看起来更舒服点。

content/zh/docs/hertz/tutorials/basic-feature/render.md Outdated Show resolved Hide resolved
@Hanser001 @rogerogers
Update content/zh/docs/hertz/tutorials/basic-feature/render.md
1458e24 
fix formats

Co-authored-by: copy rogers <40619032+rogerogers@users.noreply.github.com>
rogerogers
rogerogers reviewed May 30, 2023
View reviewed changes
Copy link
Contributor

@rogerogers rogerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

再看看，可能还有其他地方有，hertz这个单词本身不属于代码块

content/zh/docs/hertz/tutorials/basic-feature/render.md Outdated Show resolved Hide resolved
content/en/docs/hertz/tutorials/basic-feature/render.md Outdated Show resolved Hide resolved
content/zh/docs/hertz/tutorials/basic-feature/render.md Outdated Show resolved Hide resolved
content/zh/docs/hertz/tutorials/basic-feature/render.md Outdated Show resolved Hide resolved
content/zh/docs/hertz/tutorials/basic-feature/render.md Outdated Show resolved Hide resolved
content/zh/docs/hertz/tutorials/basic-feature/render.md Outdated Show resolved Hide resolved
content/zh/docs/hertz/tutorials/basic-feature/render.md Outdated Show resolved Hide resolved
content/zh/docs/hertz/tutorials/basic-feature/render.md Outdated Show resolved Hide resolved
@Hanser001 @rogerogers
Apply suggestions from code review
2489679 
Co-authored-by: copy rogers <40619032+rogerogers@users.noreply.github.com>
@Hanser001 @rogerogers
Update content/en/docs/hertz/tutorials/basic-feature/render.md
6df1766 
Co-authored-by: copy rogers <40619032+rogerogers@users.noreply.github.com>
@Hanser001
Copy link
Contributor Author

再看看，可能还有其他地方有，hertz这个单词本身不属于代码块

现在应该把Hertz这个词的部分都改好了，顺便找出了一个多余的空格

rogerogers
rogerogers previously approved these changes May 31, 2023
View reviewed changes
@li-jin-gou
Copy link
Member

HTML 不需要介绍的这么详细，高频使用的 Json 和 protobuf 还有 Data 目前使用比较最多，基本看不到用 .HTML

li-jin-gou
li-jin-gou requested changes May 31, 2023
View reviewed changes
Copy link
Member

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦补全一下文档&优化一下目录结构

li-jin-gou
li-jin-gou requested changes Jun 1, 2023
View reviewed changes
Copy link
Member

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少自定义 rendor 介绍

@li-jin-gou li-jin-gou merged commit 893df28 into cloudwego:main Jun 8, 2023
3 checks passed
li-jin-gou
li-jin-gou reviewed Jun 8, 2023
View reviewed changes
content/zh/docs/hertz/tutorials/basic-feature/render.md
示例代码：

```go
package main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺失的示例代码可以有时间补充道 hertz-example 中❤️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提交pr了🥰

@rogerogers rogerogers mentioned this pull request Aug 8, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jin-gou li-jin-gou li-jin-gou approved these changes

@rogerogers rogerogers rogerogers left review comments

Assignees

@rogerogers rogerogers

Labels
Hertz
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Hanser001 @CLAassistant @GuangmingLuo @li-jin-gou @rogerogers